Mirrors/mealie
1
0
Fork 0
mirror of https://github.com/mealie-recipes/mealie.git synced 2026-07-22 07:30:18 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: Simplify rating logic (#7918)

Browse Source
This commit is contained in:
Michael Genson
2026-07-20 15:43:08 -05:00
committed by GitHub
parent 09b877c704
commit 8a28530cdb
2 changed files with 23 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
frontend/app/components/Domain/Recipe/RecipeCardRating.vue
View File

@@ -6,8 +6,8 @@
class="star"
:class="{
'star-half': star === 'half',
'text-secondary': !useGroupStyle,
'text-grey-darken-1': useGroupStyle,
'text-secondary': !showGroupAverage,
'text-grey-darken-1': showGroupAverage,
}"
>
<!-- We render both the full and empty stars for "half" stars because they're layered over each other -->
@@ -28,7 +28,6 @@
</template>
<script setup lang="ts">
import { useLoggedInState } from "~/composables/use-logged-in-state";
import { useUserSelfRatings } from "~/composables/use-users";
type Star = "full" | "half" | "empty";
@@ -44,15 +43,17 @@ const props = defineProps({
},
});
const { isOwnGroup } = useLoggedInState();
const { userRatings } = useUserSelfRatings();
const userRating = computed(() => {
return userRatings.value.find(r => r.recipeId === props.recipeId)?.rating ?? undefined;
return userRatings.value.find(r => r.recipeId === props.recipeId)?.rating ?? null;
});
const ratingValue = computed(() => userRating.value || props.modelValue || 0);
const useGroupStyle = computed(() => isOwnGroup.value && !userRating.value && props.modelValue);
// this display is always readonly, so we show the user's own rating if they have one,
// and otherwise fall back to the group average (in grey), if there is one.
// An unset rating may be null or 0
const showGroupAverage = computed(() => !userRating.value && !!props.modelValue);
const ratingValue = computed(() => (showGroupAverage.value ? props.modelValue : userRating.value) || 0);
const ratingDisplay = computed<Star[]>(
() => {
const stars: Star[] = [];