improve developer tooling (backend) (#1051)

* add basic pre-commit file

* add flake8

* add isort

* add pep585-upgrade (typing upgrades)

* use namespace for import

* add mypy

* update ci for backend

* flake8 scope

* fix version format

* update makefile

* disable strict option (temporary)

* fix mypy issues

* upgrade type hints (pre-commit)

* add vscode typing check

* add types to dev deps

* remote container draft

* update setup script

* update compose version

* run setup on create

* dev containers update

* remove unused pages

* update setup tips

* expose ports

* Update pre-commit to include flask8-print (#1053)

* Add in flake8-print to pre-commit

* pin version of flake8-print

* formatting

* update getting strated docs

* add mypy to pre-commit

* purge .mypy_cache on clean

* drop mypy

Co-authored-by: zackbcom <zackbcom@users.noreply.github.com>

mealie/core/dependencies/dependencies.py

@@ -1,5 +1,6 @@
 import shutil
 import tempfile
+from collections.abc import AsyncGenerator, Callable, Generator
 from pathlib import Path
 from typing import Optional
 from uuid import uuid4
@@ -94,10 +95,11 @@ def validate_long_live_token(session: Session, client_token: str, id: int) -> Pr
     tokens: list[LongLiveTokenInDB] = repos.api_tokens.get(id, "user_id", limit=9999)
 
     for token in tokens:
-        token: LongLiveTokenInDB
         if token.token == client_token:
             return token.user
 
+    raise HTTPException(status_code=status.HTTP_401_UNAUTHORIZED, detail="Invalid Token")
+
 
 def validate_file_token(token: Optional[str] = None) -> Path:
     credentials_exception = HTTPException(
@@ -133,7 +135,7 @@ def validate_recipe_token(token: Optional[str] = None) -> str:
     return slug
 
 
-async def temporary_zip_path() -> Path:
+async def temporary_zip_path() -> AsyncGenerator[Path, None]:
     app_dirs.TEMP_DIR.mkdir(exist_ok=True, parents=True)
     temp_path = app_dirs.TEMP_DIR.joinpath("my_zip_archive.zip")
 
@@ -143,7 +145,7 @@ async def temporary_zip_path() -> Path:
         temp_path.unlink(missing_ok=True)
 
 
-async def temporary_dir() -> Path:
+async def temporary_dir() -> AsyncGenerator[Path, None]:
     temp_path = app_dirs.TEMP_DIR.joinpath(uuid4().hex)
     temp_path.mkdir(exist_ok=True, parents=True)
 
@@ -153,12 +155,12 @@ async def temporary_dir() -> Path:
         shutil.rmtree(temp_path)
 
 
-def temporary_file(ext: str = "") -> Path:
+def temporary_file(ext: str = "") -> Callable[[], Generator[tempfile._TemporaryFileWrapper, None, None]]:
     """
     Returns a temporary file with the specified extension
     """
 
-    def func() -> Path:
+    def func():
         temp_path = app_dirs.TEMP_DIR.joinpath(uuid4().hex + ext)
         temp_path.touch()
 

mealie/core/root_logger.py

@@ -20,7 +20,7 @@ class LoggerConfig:
     format: str
     date_format: str
     logger_file: str
-    level: str = logging.INFO
+    level: int = logging.INFO
 
 
 @lru_cache

mealie/core/security.py

@@ -36,7 +36,7 @@ def create_recipe_slug_token(file_path: str) -> str:
     return create_access_token(token_data, expires_delta=timedelta(minutes=30))
 
 
-def user_from_ldap(db: AllRepositories, session, username: str, password: str) -> PrivateUser:
+def user_from_ldap(db: AllRepositories, session, username: str, password: str) -> PrivateUser | bool:
     """Given a username and password, tries to authenticate by BINDing to an
     LDAP server
 

mealie/core/settings/db_providers.py

@@ -35,7 +35,7 @@ class PostgresProvider(AbstractDBProvider, BaseSettings):
     POSTGRES_USER: str = "mealie"
     POSTGRES_PASSWORD: str = "mealie"
     POSTGRES_SERVER: str = "postgres"
-    POSTGRES_PORT: str = 5432
+    POSTGRES_PORT: str = "5432"
     POSTGRES_DB: str = "mealie"
 
     @property

mealie/core/settings/settings.py

@@ -2,7 +2,7 @@ import secrets
 from pathlib import Path
 from typing import Optional
 
-from pydantic import BaseSettings
+from pydantic import BaseSettings, NoneStr
 
 from .db_providers import AbstractDBProvider, db_provider_factory
 
@@ -33,26 +33,26 @@ class AppSettings(BaseSettings):
     SECRET: str
 
     @property
-    def DOCS_URL(self) -> str:
+    def DOCS_URL(self) -> str | None:
         return "/docs" if self.API_DOCS else None
 
     @property
-    def REDOC_URL(self) -> str:
+    def REDOC_URL(self) -> str | None:
         return "/redoc" if self.API_DOCS else None
 
     # ===============================================
     # Database Configuration
 
     DB_ENGINE: str = "sqlite"  # Options: 'sqlite', 'postgres'
-    DB_PROVIDER: AbstractDBProvider = None
+    DB_PROVIDER: Optional[AbstractDBProvider] = None
 
     @property
-    def DB_URL(self) -> str:
-        return self.DB_PROVIDER.db_url
+    def DB_URL(self) -> str | None:
+        return self.DB_PROVIDER.db_url if self.DB_PROVIDER else None
 
     @property
-    def DB_URL_PUBLIC(self) -> str:
-        return self.DB_PROVIDER.db_url_public
+    def DB_URL_PUBLIC(self) -> str | None:
+        return self.DB_PROVIDER.db_url_public if self.DB_PROVIDER else None
 
     DEFAULT_GROUP: str = "Home"
     DEFAULT_EMAIL: str = "changeme@email.com"
@@ -88,9 +88,9 @@ class AppSettings(BaseSettings):
     # LDAP Configuration
 
     LDAP_AUTH_ENABLED: bool = False
-    LDAP_SERVER_URL: str = None
-    LDAP_BIND_TEMPLATE: str = None
-    LDAP_ADMIN_FILTER: str = None
+    LDAP_SERVER_URL: NoneStr = None
+    LDAP_BIND_TEMPLATE: NoneStr = None
+    LDAP_ADMIN_FILTER: NoneStr = None
 
     @property
     def LDAP_ENABLED(self) -> bool: