Files
coredns/plugin/metrics/recorder_test.go
Ville Vesilehto be934b2b06 perf(metrics): implement plugin chain tracking (#7791)
Remove expensive runtime.Caller calls from metrics Recorder.WriteMsg
by tracking the responding plugin through the plugin chain instead.

- Add PluginTracker interface and pluginWriter wrapper in plugin.go
- Modify NextOrFailure to wrap ResponseWriter with plugin name
- Update metrics Recorder to implement PluginTracker
- Remove authoritativePlugin method using filepath inspection

Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
2025-12-29 14:33:12 -08:00

97 lines
2.3 KiB
Go

package metrics
import (
"testing"
"github.com/coredns/coredns/plugin/test"
"github.com/miekg/dns"
)
type inmemoryWriter struct {
test.ResponseWriter
written []byte
}
func (r *inmemoryWriter) WriteMsg(m *dns.Msg) error {
r.written, _ = m.Pack()
return r.ResponseWriter.WriteMsg(m)
}
func (r *inmemoryWriter) Write(buf []byte) (int, error) {
r.written = buf
return r.ResponseWriter.Write(buf)
}
func TestRecorder_PluginTracker(t *testing.T) {
tw := inmemoryWriter{ResponseWriter: test.ResponseWriter{}}
rec := NewRecorder(&tw)
// Initially Plugin should be empty
if rec.Plugin != "" {
t.Errorf("Expected empty Plugin, got %q", rec.Plugin)
}
if rec.GetPlugin() != "" {
t.Errorf("Expected GetPlugin() to return empty string, got %q", rec.GetPlugin())
}
// SetPlugin should set the plugin name
rec.SetPlugin("whoami")
if rec.Plugin != "whoami" {
t.Errorf("Expected Plugin to be 'whoami', got %q", rec.Plugin)
}
if rec.GetPlugin() != "whoami" {
t.Errorf("Expected GetPlugin() to return 'whoami', got %q", rec.GetPlugin())
}
// SetPlugin should overwrite previous value
rec.SetPlugin("cache")
if rec.Plugin != "cache" {
t.Errorf("Expected Plugin to be 'cache', got %q", rec.Plugin)
}
}
func TestRecorder_WriteMsg(t *testing.T) {
successResp := dns.Msg{}
successResp.Answer = []dns.RR{
test.A("a.example.org. 1800 IN A 127.0.0.53"),
}
nxdomainResp := dns.Msg{}
nxdomainResp.Rcode = dns.RcodeNameError
tests := []struct {
name string
msg *dns.Msg
}{
{
name: "should record successful response",
msg: &successResp,
},
{
name: "should record nxdomain response",
msg: &nxdomainResp,
},
}
for i, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
tw := inmemoryWriter{ResponseWriter: test.ResponseWriter{}}
rec := NewRecorder(&tw)
if err := rec.WriteMsg(tt.msg); err != nil {
t.Errorf("Test %d: WriteMsg() unexpected error %v", i, err)
}
if rec.Msg != tt.msg {
t.Errorf("Test %d: Expected value %v for msg, but got %v", i, tt.msg, rec.Msg)
}
if rec.Len != tt.msg.Len() {
t.Errorf("Test %d: Expected value %d for len, but got %d", i, tt.msg.Len(), rec.Len)
}
if rec.Rcode != tt.msg.Rcode {
t.Errorf("Test %d: Expected value %d for rcode, but got %d", i, tt.msg.Rcode, rec.Rcode)
}
})
}
}