coredns/plugin/rewrite/rcode_test.go

package rewrite

import (
	"context"
	"strings"
	"testing"

	"github.com/coredns/coredns/plugin"
	"github.com/coredns/coredns/plugin/test"
	"github.com/coredns/coredns/request"

	"github.com/miekg/dns"
)

func TestNewRCodeRule(t *testing.T) {
	tests := []struct {
		next         string
		args         []string
		expectedFail bool
	}{
		{"stop", []string{"numeric.rcode.coredns.rocks", "2", "0"}, false},
		{"stop", []string{"too.few.rcode.coredns.rocks", "2"}, true},
		{"stop", []string{"exact", "too.many.rcode.coredns.rocks", "2", "1", "0"}, true},
		{"stop", []string{"exact", "match.string.rcode.coredns.rocks", "SERVFAIL", "NOERROR"}, false},
		{"continue", []string{"regex", `(regex)\.rcode\.(coredns)\.(rocks)`, "FORMERR", "NOERROR"}, false},
		{"stop", []string{"invalid.rcode.coredns.rocks", "random", "nothing"}, true},
	}
	for i, tc := range tests {
		failed := false
		rule, err := newRCodeRule(tc.next, tc.args...)
		if err != nil {
			failed = true
		}
		if !failed && !tc.expectedFail {
			continue
		}
		if failed && tc.expectedFail {
			continue
		}
		t.Fatalf("Test %d: FAIL, expected fail=%t, but received fail=%t: (%s) %s, rule=%v, err=%v", i, tc.expectedFail, failed, tc.next, tc.args, rule, err)
	}
	for i, tc := range tests {
		failed := false
		tc.args = append([]string{tc.next, "rcode"}, tc.args...)
		rule, err := newRule(tc.args...)
		if err != nil {
			failed = true
		}
		if !failed && !tc.expectedFail {
			continue
		}
		if failed && tc.expectedFail {
			continue
		}
		t.Fatalf("Test %d: FAIL, expected fail=%t, but received fail=%t: (%s) %s, rule=%v, err=%v", i, tc.expectedFail, failed, tc.next, tc.args, rule, err)
	}
}

func TestRCodeRewrite(t *testing.T) {
	rule, err := newRCodeRule("stop", []string{"exact", "srv1.coredns.rocks", "SERVFAIL", "FORMERR"}...)

	m := new(dns.Msg)
	m.SetQuestion("srv1.coredns.rocks.", dns.TypeA)
	m.Question[0].Qclass = dns.ClassINET
	m.Answer = []dns.RR{test.A("srv1.coredns.rocks.  5   IN  A  10.0.0.1")}
	m.Rcode = dns.RcodeServerFailure
	request := request.Request{Req: m}

	rcRule, _ := rule.(*exactRCodeRule)
	var rr dns.RR
	rcRule.response.RewriteResponse(request.Req, rr)
	if request.Req.Rcode != dns.RcodeFormatError {
		t.Fatalf("RCode rewrite did not apply changes, request=%#v, err=%v", request.Req, err)
	}
}

// TestRCodeRewriteEmptyResponse drives an rcode rewrite end-to-end through
// ServeDNS for a response that carries no resource records, such as a bare
// SERVFAIL from a downstream plugin. Rewriting SERVFAIL to NOERROR is the
// plugin's documented use case (see README.md), and a non-EDNS client's failure
// reply has no answer, authority or additional records, so the rewrite must be
// applied at the message level rather than only per record.
func TestRCodeRewriteEmptyResponse(t *testing.T) {
	for _, mode := range []string{"stop", "continue"} {
		for _, oldRcode := range []int{
			dns.RcodeFormatError,
			dns.RcodeServerFailure,
			dns.RcodeRefused,
			dns.RcodeNotImplemented,
		} {
			t.Run(mode+"/"+dns.RcodeToString[oldRcode], func(t *testing.T) {
				rule, err := newRCodeRule(mode, "exact", "srv1.coredns.rocks", dns.RcodeToString[oldRcode], "NOERROR")
				if err != nil {
					t.Fatal(err)
				}
				// Downstream plugin fails without writing a response of its own.
				next := plugin.HandlerFunc(func(_ context.Context, _ dns.ResponseWriter, _ *dns.Msg) (int, error) {
					return oldRcode, nil
				})
				req := new(dns.Msg)
				req.SetQuestion("srv1.coredns.rocks.", dns.TypeA) // no EDNS OPT record

				resp := serveEdns0Rewrite(t, rule, next, req)
				if resp == nil {
					t.Fatal("no response was written to the client")
				}
				if resp.Rcode != dns.RcodeSuccess {
					t.Fatalf("expected RCODE rewritten to NOERROR (%d), got %s (%d)",
						dns.RcodeSuccess, dns.RcodeToString[resp.Rcode], resp.Rcode)
				}
			})
		}
	}
}

func TestNewRCodeRuleLargeRegex(t *testing.T) {
	largeRegex := strings.Repeat("a", maxRegexpLen+1)
	_, err := newRCodeRule("stop", "regex", largeRegex, "SERVFAIL", "NXDOMAIN")
	if err == nil {
		t.Fatal("Expected error for large regex, got nil")
	}
	if !strings.Contains(err.Error(), "too long") {
		t.Errorf("Expected 'too long' error, got: %v", err)
	}
}