mirror of
https://github.com/coredns/coredns.git
synced 2026-01-01 14:31:23 -05:00
7b38eb8625
Fix integer overflow conversion warnings (G115) by adding appropriate suppressions where values are provably bounded. Fixes: https://github.com/coredns/coredns/issues/7793 Changes: - Updated 56 G115 annotations to use consistent // #nosec G115 format - Added 2 //nolint:gosec suppressions for conditional expressions - Removed G115 exclusion from golangci.yml (now explicitly handled per-line) Suppressions justify why each conversion is safe (e.g., port numbers are bounded 1-65535, DNS TTL limits, pool lengths, etc.) Signed-off-by: Azeez Syed <syedazeez337@gmail.com>
98 lines
2.5 KiB
Go
98 lines
2.5 KiB
Go
package msg
|
|
|
|
import (
|
|
"fmt"
|
|
"net"
|
|
"time"
|
|
|
|
tap "github.com/dnstap/golang-dnstap"
|
|
)
|
|
|
|
var (
|
|
protoUDP = tap.SocketProtocol_UDP
|
|
protoTCP = tap.SocketProtocol_TCP
|
|
familyINET = tap.SocketFamily_INET
|
|
familyINET6 = tap.SocketFamily_INET6
|
|
)
|
|
|
|
// SetQueryAddress adds the query address to the message. This also sets the SocketFamily and SocketProtocol.
|
|
func SetQueryAddress(t *tap.Message, addr net.Addr) error {
|
|
t.SocketFamily = &familyINET
|
|
switch a := addr.(type) {
|
|
case *net.TCPAddr:
|
|
t.SocketProtocol = &protoTCP
|
|
t.QueryAddress = a.IP
|
|
|
|
p := uint32(a.Port) // #nosec G115 -- Port is inherently bounded (1-65535)
|
|
t.QueryPort = &p
|
|
|
|
if a.IP.To4() == nil {
|
|
t.SocketFamily = &familyINET6
|
|
}
|
|
return nil
|
|
case *net.UDPAddr:
|
|
t.SocketProtocol = &protoUDP
|
|
t.QueryAddress = a.IP
|
|
|
|
p := uint32(a.Port) // #nosec G115 -- Port is inherently bounded (1-65535)
|
|
t.QueryPort = &p
|
|
|
|
if a.IP.To4() == nil {
|
|
t.SocketFamily = &familyINET6
|
|
}
|
|
return nil
|
|
default:
|
|
return fmt.Errorf("unknown address type: %T", a)
|
|
}
|
|
}
|
|
|
|
// SetResponseAddress the response address to the message. This also sets the SocketFamily and SocketProtocol.
|
|
func SetResponseAddress(t *tap.Message, addr net.Addr) error {
|
|
t.SocketFamily = &familyINET
|
|
switch a := addr.(type) {
|
|
case *net.TCPAddr:
|
|
t.SocketProtocol = &protoTCP
|
|
t.ResponseAddress = a.IP
|
|
|
|
p := uint32(a.Port) // #nosec G115 -- Port is inherently bounded (1-65535)
|
|
t.ResponsePort = &p
|
|
|
|
if a.IP.To4() == nil {
|
|
t.SocketFamily = &familyINET6
|
|
}
|
|
return nil
|
|
case *net.UDPAddr:
|
|
t.SocketProtocol = &protoUDP
|
|
t.ResponseAddress = a.IP
|
|
|
|
p := uint32(a.Port) // #nosec G115 -- Port is inherently bounded (1-65535)
|
|
t.ResponsePort = &p
|
|
|
|
if a.IP.To4() == nil {
|
|
t.SocketFamily = &familyINET6
|
|
}
|
|
return nil
|
|
default:
|
|
return fmt.Errorf("unknown address type: %T", a)
|
|
}
|
|
}
|
|
|
|
// SetQueryTime sets the time of the query in t.
|
|
func SetQueryTime(t *tap.Message, ti time.Time) {
|
|
qts := uint64(ti.Unix()) // #nosec G115 -- Unix time fits in uint64
|
|
qtn := uint32(ti.Nanosecond()) // #nosec G115 -- Nanoseconds (0-999999999) fit in uint32
|
|
t.QueryTimeSec = &qts
|
|
t.QueryTimeNsec = &qtn
|
|
}
|
|
|
|
// SetResponseTime sets the time of the response in t.
|
|
func SetResponseTime(t *tap.Message, ti time.Time) {
|
|
rts := uint64(ti.Unix()) // #nosec G115 -- Unix time fits in uint64
|
|
rtn := uint32(ti.Nanosecond()) // #nosec G115 -- Nanoseconds (0-999999999) fit in uint32
|
|
t.ResponseTimeSec = &rts
|
|
t.ResponseTimeNsec = &rtn
|
|
}
|
|
|
|
// SetType sets the type in t.
|
|
func SetType(t *tap.Message, typ tap.Message_Type) { t.Type = &typ }
|