coredns/core/dnsserver/config_test.go

package dnsserver

import (
	"testing"

	"github.com/coredns/caddy"
	"github.com/coredns/coredns/plugin"

	"github.com/miekg/dns"
)

func TestKeyForConfig(t *testing.T) {
	tests := []struct {
		name          string
		blockIndex    int
		blockKeyIndex int
		expected      string
	}{
		{"zero_indices", 0, 0, "0:0"},
		{"positive_indices", 1, 2, "1:2"},
		{"larger_indices", 10, 5, "10:5"},
	}

	for _, tc := range tests {
		t.Run(tc.name, func(t *testing.T) {
			result := keyForConfig(tc.blockIndex, tc.blockKeyIndex)
			if result != tc.expected {
				t.Errorf("Expected %s, got %s for blockIndex %d and blockKeyIndex %d",
					tc.expected, result, tc.blockIndex, tc.blockKeyIndex)
			}
		})
	}
}

func TestGetConfig(t *testing.T) {
	controller := caddy.NewTestController("dns", "")
	initialCtx := controller.Context()
	dnsCtx, ok := initialCtx.(*dnsContext)
	if !ok {
		t.Fatalf("controller.Context() did not return a *dnsContext, got %T", initialCtx)
	}
	if dnsCtx.keysToConfigs == nil {
		t.Fatal("dnsCtx.keysToConfigs is nil; it should have been initialized by newContext")
	}

	t.Run("returns and saves default config when config missing", func(t *testing.T) {
		controller.ServerBlockIndex = 0
		controller.ServerBlockKeyIndex = 0
		key := keyForConfig(controller.ServerBlockIndex, controller.ServerBlockKeyIndex)

		// Ensure config doesn't exist initially for this specific key
		delete(dnsCtx.keysToConfigs, key)

		cfg := GetConfig(controller)
		if cfg == nil {
			t.Fatal("GetConfig returned nil (should create and return a default)")
		}
		if len(cfg.ListenHosts) != 1 || cfg.ListenHosts[0] != "" {
			t.Errorf("Expected default ListenHosts [\"\"] for auto-created config, got %v", cfg.ListenHosts)
		}

		savedCfg, found := dnsCtx.keysToConfigs[key]
		if !found {
			t.Fatal("fallback did not save the default config into the context")
		}
		if savedCfg != cfg {
			t.Fatal("config is not the same instance as the one saved in the context")
		}
	})
}

func TestAddPluginToAllServerBlocks(t *testing.T) {
	c := caddy.NewTestController("dns", "")
	ctx := c.Context().(*dnsContext)
	first := &Config{}
	secondZone := &Config{firstConfigInBlock: first}
	third := &Config{}
	first.firstConfigInBlock = first
	third.firstConfigInBlock = third
	ctx.configs = []*Config{first, secondZone, third}

	AddPluginToAllServerBlocks(c, func(next plugin.Handler) plugin.Handler { return next })

	if got := len(first.Plugin); got != 1 {
		t.Fatalf("first server block has %d plugins, want 1", got)
	}
	if got := len(secondZone.Plugin); got != 0 {
		t.Fatalf("secondary zone has %d plugins before propagation, want 0", got)
	}
	if got := len(third.Plugin); got != 1 {
		t.Fatalf("second server block has %d plugins, want 1", got)
	}
}

func TestPropagateConfigParamsMaxTCPQueries(t *testing.T) {
	n := 128
	first := &Config{MaxTCPQueries: &n}
	first.firstConfigInBlock = first
	second := &Config{firstConfigInBlock: first}

	propagateConfigParams([]*Config{first, second})

	if second.MaxTCPQueries == nil || *second.MaxTCPQueries != n {
		t.Fatalf("expected MaxTCPQueries to propagate to second config as %d, got %v", n, second.MaxTCPQueries)
	}
}

func TestPropagateConfigParamsAllowedOpcodes(t *testing.T) {
	first := &Config{}
	first.firstConfigInBlock = first
	first.AllowOpcode(dns.OpcodeUpdate)
	second := &Config{firstConfigInBlock: first}

	propagateConfigParams([]*Config{first, second})

	if !second.acceptsOpcode(dns.OpcodeUpdate) {
		t.Fatal("expected UPDATE admission to propagate to every zone in the server block")
	}
}