mirror of
https://github.com/coredns/coredns.git
synced 2026-08-20 23:08:28 -04:00
* plugin/rewrite: apply rcode rewrites to record-less responses An rcode rewrite rewrites the message-level RCODE, but the reverter only ran response rules from inside the per-record loops in WriteMsg. When a response carries no answer, authority or additional records - for example a bare SERVFAIL that a downstream plugin returns to a non-EDNS client - none of the loops iterate, so the rcode rewrite was silently skipped and the client received the original RCODE. Apply message-level response rules once when the response has no records, using a small marker interface that mirrors the existing requestExtraRevertRule pattern. This fixes the plugin's documented SERVFAIL-to-NOERROR use case for responses without records. Signed-off-by: Sueun Cho <sueun.dev@gmail.com> * plugin/rewrite: apply fallback rcode rewrites for continue Signed-off-by: Sueun Cho <sueun.dev@gmail.com> --------- Signed-off-by: Sueun Cho <sueun.dev@gmail.com>
237 lines
6.3 KiB
Go
237 lines
6.3 KiB
Go
package rewrite
|
|
|
|
import (
|
|
"github.com/miekg/dns"
|
|
)
|
|
|
|
// RevertPolicy controls the overall reverting process
|
|
type RevertPolicy interface {
|
|
DoRevert() bool
|
|
DoQuestionRestore() bool
|
|
}
|
|
|
|
type revertPolicy struct {
|
|
noRevert bool
|
|
noRestore bool
|
|
}
|
|
|
|
func (p revertPolicy) DoRevert() bool {
|
|
return !p.noRevert
|
|
}
|
|
|
|
func (p revertPolicy) DoQuestionRestore() bool {
|
|
return !p.noRestore
|
|
}
|
|
|
|
// NoRevertPolicy disables all response rewrite rules
|
|
func NoRevertPolicy() RevertPolicy {
|
|
return revertPolicy{true, false}
|
|
}
|
|
|
|
// NoRestorePolicy disables the question restoration during the response rewrite
|
|
func NoRestorePolicy() RevertPolicy {
|
|
return revertPolicy{false, true}
|
|
}
|
|
|
|
// NewRevertPolicy creates a new reverter policy by dynamically specifying all
|
|
// options.
|
|
func NewRevertPolicy(noRevert, noRestore bool) RevertPolicy {
|
|
return revertPolicy{noRestore: noRestore, noRevert: noRevert}
|
|
}
|
|
|
|
// ResponseRule contains a rule to rewrite a response with.
|
|
type ResponseRule interface {
|
|
RewriteResponse(res *dns.Msg, rr dns.RR)
|
|
}
|
|
|
|
type requestExtraRevertRule interface {
|
|
ResponseRule
|
|
revertRequestExtra()
|
|
}
|
|
|
|
// msgResponseRule is a ResponseRule that rewrites message-level fields, which
|
|
// are independent of any resource record (for example the RCODE). Such a rule
|
|
// must still be applied when the response carries no records.
|
|
type msgResponseRule interface {
|
|
ResponseRule
|
|
rewriteMsg()
|
|
}
|
|
|
|
// ResponseRules describes an ordered list of response rules to apply
|
|
// after a name rewrite
|
|
type ResponseRules = []ResponseRule
|
|
|
|
// ResponseReverter reverses the operations done on the question section of a packet.
|
|
// This is need because the client will otherwise disregards the response, i.e.
|
|
// dig will complain with ';; Question section mismatch: got example.org/HINFO/IN'
|
|
type ResponseReverter struct {
|
|
dns.ResponseWriter
|
|
originalQuestion dns.Question
|
|
request *dns.Msg
|
|
ResponseRules ResponseRules
|
|
revertPolicy RevertPolicy
|
|
}
|
|
|
|
// NewResponseReverter returns a pointer to a new ResponseReverter.
|
|
func NewResponseReverter(w dns.ResponseWriter, r *dns.Msg, policy RevertPolicy) *ResponseReverter {
|
|
return &ResponseReverter{
|
|
ResponseWriter: w,
|
|
originalQuestion: r.Question[0],
|
|
request: r,
|
|
revertPolicy: policy,
|
|
}
|
|
}
|
|
|
|
// WriteMsg records the status code and calls the underlying ResponseWriter's WriteMsg method.
|
|
func (r *ResponseReverter) WriteMsg(res1 *dns.Msg) error {
|
|
// Deep copy 'res' as to not (e.g). rewrite a message that's also stored in the cache.
|
|
res := res1.Copy()
|
|
|
|
if r.revertPolicy.DoQuestionRestore() {
|
|
if len(res.Question) == 0 {
|
|
res.Question = []dns.Question{r.originalQuestion}
|
|
} else {
|
|
res.Question[0] = r.originalQuestion
|
|
}
|
|
}
|
|
if len(r.ResponseRules) > 0 {
|
|
for _, rr := range res.Ns {
|
|
r.rewriteResourceRecord(res, rr)
|
|
}
|
|
for _, rr := range res.Answer {
|
|
r.rewriteResourceRecord(res, rr)
|
|
}
|
|
for _, rr := range res.Extra {
|
|
r.rewriteResourceRecord(res, rr)
|
|
}
|
|
// Message-level response rules (e.g. rcode) rewrite header fields that
|
|
// are independent of any resource record. The per-record loops above
|
|
// never run them when the response carries no records (e.g. a bare
|
|
// SERVFAIL from a downstream plugin), so apply them once here.
|
|
if len(res.Ns) == 0 && len(res.Answer) == 0 && len(res.Extra) == 0 {
|
|
r.rewriteMsg(res)
|
|
}
|
|
}
|
|
return r.writeWithRevertedRequestExtra(res)
|
|
}
|
|
|
|
func (r *ResponseReverter) writeWithRevertedRequestExtra(res *dns.Msg) error {
|
|
if r.request == nil || !r.hasRequestExtraRevertRule() {
|
|
return r.ResponseWriter.WriteMsg(res)
|
|
}
|
|
|
|
currentExtra := r.request.Extra
|
|
req := new(dns.Msg)
|
|
req.Extra = copyRRs(currentExtra)
|
|
for _, rr := range req.Extra {
|
|
r.rewriteRequestExtra(req, rr)
|
|
}
|
|
r.request.Extra = req.Extra
|
|
defer func() {
|
|
r.request.Extra = currentExtra
|
|
}()
|
|
|
|
return r.ResponseWriter.WriteMsg(res)
|
|
}
|
|
|
|
func (r *ResponseReverter) hasRequestExtraRevertRule() bool {
|
|
for _, rule := range r.ResponseRules {
|
|
if _, ok := rule.(requestExtraRevertRule); ok {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
func copyRRs(rrs []dns.RR) []dns.RR {
|
|
if len(rrs) == 0 {
|
|
return nil
|
|
}
|
|
copied := make([]dns.RR, len(rrs))
|
|
for i, rr := range rrs {
|
|
copied[i] = dns.Copy(rr)
|
|
}
|
|
return copied
|
|
}
|
|
|
|
func (r *ResponseReverter) rewriteResourceRecord(res *dns.Msg, rr dns.RR) {
|
|
// The reverting rules need to be done in reversed order.
|
|
for i := len(r.ResponseRules) - 1; i >= 0; i-- {
|
|
r.ResponseRules[i].RewriteResponse(res, rr)
|
|
}
|
|
}
|
|
|
|
// rewriteMsg applies the message-level response rules once, in reversed order.
|
|
// It is used for responses that carry no resource records, where the per-record
|
|
// loops in WriteMsg would otherwise never apply them.
|
|
func (r *ResponseReverter) rewriteMsg(res *dns.Msg) {
|
|
// The reverting rules need to be done in reversed order.
|
|
for i := len(r.ResponseRules) - 1; i >= 0; i-- {
|
|
if _, ok := r.ResponseRules[i].(msgResponseRule); !ok {
|
|
continue
|
|
}
|
|
r.ResponseRules[i].RewriteResponse(res, nil)
|
|
}
|
|
}
|
|
|
|
func (r *ResponseReverter) rewriteRequestExtra(req *dns.Msg, rr dns.RR) {
|
|
// The reverting rules need to be done in reversed order.
|
|
for i := len(r.ResponseRules) - 1; i >= 0; i-- {
|
|
rule, ok := r.ResponseRules[i].(requestExtraRevertRule)
|
|
if !ok {
|
|
continue
|
|
}
|
|
rule.RewriteResponse(req, rr)
|
|
}
|
|
}
|
|
|
|
// Write is a wrapper that records the size of the message that gets written.
|
|
func (r *ResponseReverter) Write(buf []byte) (int, error) {
|
|
n, err := r.ResponseWriter.Write(buf)
|
|
return n, err
|
|
}
|
|
|
|
func getRecordValueForRewrite(rr dns.RR) (name string) {
|
|
switch rr.Header().Rrtype {
|
|
case dns.TypeSRV:
|
|
return rr.(*dns.SRV).Target
|
|
case dns.TypeMX:
|
|
return rr.(*dns.MX).Mx
|
|
case dns.TypeCNAME:
|
|
return rr.(*dns.CNAME).Target
|
|
case dns.TypeNS:
|
|
return rr.(*dns.NS).Ns
|
|
case dns.TypeDNAME:
|
|
return rr.(*dns.DNAME).Target
|
|
case dns.TypeNAPTR:
|
|
return rr.(*dns.NAPTR).Replacement
|
|
case dns.TypeSOA:
|
|
return rr.(*dns.SOA).Ns
|
|
case dns.TypePTR:
|
|
return rr.(*dns.PTR).Ptr
|
|
default:
|
|
return ""
|
|
}
|
|
}
|
|
|
|
func setRewrittenRecordValue(rr dns.RR, value string) {
|
|
switch rr.Header().Rrtype {
|
|
case dns.TypeSRV:
|
|
rr.(*dns.SRV).Target = value
|
|
case dns.TypeMX:
|
|
rr.(*dns.MX).Mx = value
|
|
case dns.TypeCNAME:
|
|
rr.(*dns.CNAME).Target = value
|
|
case dns.TypeNS:
|
|
rr.(*dns.NS).Ns = value
|
|
case dns.TypeDNAME:
|
|
rr.(*dns.DNAME).Target = value
|
|
case dns.TypeNAPTR:
|
|
rr.(*dns.NAPTR).Replacement = value
|
|
case dns.TypeSOA:
|
|
rr.(*dns.SOA).Ns = value
|
|
case dns.TypePTR:
|
|
rr.(*dns.PTR).Ptr = value
|
|
}
|
|
}
|