mirror of
https://github.com/coredns/coredns.git
synced 2026-05-25 19:30:23 -04:00
3080ec0448
Enable errorlint and preserve wrapped error chains so runtime checks and tests classify failures correctly. This also makes Route53 surface insert failures instead of silently dropping them. Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
296 lines
9.7 KiB
Go
296 lines
9.7 KiB
Go
package route53
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"reflect"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/coredns/coredns/plugin/pkg/dnstest"
|
|
"github.com/coredns/coredns/plugin/pkg/fall"
|
|
"github.com/coredns/coredns/plugin/test"
|
|
crequest "github.com/coredns/coredns/request"
|
|
|
|
"github.com/aws/aws-sdk-go-v2/aws"
|
|
"github.com/aws/aws-sdk-go-v2/service/route53"
|
|
"github.com/aws/aws-sdk-go-v2/service/route53/types"
|
|
"github.com/miekg/dns"
|
|
)
|
|
|
|
type fakeRoute53 struct {
|
|
route53Client
|
|
}
|
|
|
|
func (fakeRoute53) ListHostedZonesByName(_ context.Context, _input *route53.ListHostedZonesByNameInput, _optFns ...func(*route53.Options)) (*route53.ListHostedZonesByNameOutput, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
func (fakeRoute53) ListResourceRecordSets(_ context.Context, in *route53.ListResourceRecordSetsInput, _optFns ...func(*route53.Options)) (*route53.ListResourceRecordSetsOutput, error) {
|
|
if aws.ToString(in.HostedZoneId) == "0987654321" {
|
|
return nil, errors.New("bad. zone is bad")
|
|
}
|
|
rrsResponse := map[string][]types.ResourceRecordSet{}
|
|
for _, r := range []struct {
|
|
rType types.RRType
|
|
name, value, hostedZoneID string
|
|
}{
|
|
{"A", "example.org.", "1.2.3.4", "1234567890"},
|
|
{"A", "www.example.org", "1.2.3.4", "1234567890"},
|
|
{"CNAME", `\052.www.example.org`, "www.example.org", "1234567890"},
|
|
{"AAAA", "example.org.", "2001:db8:85a3::8a2e:370:7334", "1234567890"},
|
|
{"CNAME", "sample.example.org.", "example.org", "1234567890"},
|
|
{"PTR", "example.org.", "ptr.example.org.", "1234567890"},
|
|
{"SOA", "org.", "ns-1536.awsdns-00.co.uk. awsdns-hostmaster.amazon.com. 1 7200 900 1209600 86400", "1234567890"},
|
|
{"NS", "com.", "ns-1536.awsdns-00.co.uk.", "1234567890"},
|
|
{"A", "split-example.gov.", "1.2.3.4", "1234567890"},
|
|
// Unsupported type should be ignored.
|
|
{"YOLO", "swag.", "foobar", "1234567890"},
|
|
// Hosted zone with the same name, but a different id.
|
|
{"A", "other-example.org.", "3.5.7.9", "1357986420"},
|
|
{"A", "split-example.org.", "1.2.3.4", "1357986420"},
|
|
{"SOA", "org.", "ns-15.awsdns-00.co.uk. awsdns-hostmaster.amazon.com. 1 7200 900 1209600 86400", "1357986420"},
|
|
// Hosted zone without SOA.
|
|
} {
|
|
rrs, ok := rrsResponse[r.hostedZoneID]
|
|
if !ok {
|
|
rrs = make([]types.ResourceRecordSet, 0)
|
|
}
|
|
rrs = append(rrs, types.ResourceRecordSet{Type: r.rType,
|
|
Name: aws.String(r.name),
|
|
ResourceRecords: []types.ResourceRecord{
|
|
{
|
|
Value: aws.String(r.value),
|
|
},
|
|
},
|
|
TTL: aws.Int64(300),
|
|
})
|
|
rrsResponse[r.hostedZoneID] = rrs
|
|
}
|
|
|
|
return &route53.ListResourceRecordSetsOutput{
|
|
ResourceRecordSets: rrsResponse[aws.ToString(in.HostedZoneId)],
|
|
IsTruncated: false,
|
|
}, nil
|
|
}
|
|
|
|
func TestRoute53(t *testing.T) {
|
|
ctx := t.Context()
|
|
|
|
r, err := New(ctx, fakeRoute53{}, map[string][]string{"bad.": {"0987654321"}}, time.Minute)
|
|
if err != nil {
|
|
t.Fatalf("Failed to create route53: %v", err)
|
|
}
|
|
if err = r.Run(ctx); err == nil {
|
|
t.Fatalf("Expected errors for zone bad.")
|
|
}
|
|
|
|
r, err = New(ctx, fakeRoute53{}, map[string][]string{"org.": {"1357986420", "1234567890"}, "gov.": {"Z098765432", "1234567890"}}, 90*time.Second)
|
|
if err != nil {
|
|
t.Fatalf("Failed to create route53: %v", err)
|
|
}
|
|
r.Fall = fall.Zero
|
|
r.Fall.SetZonesFromArgs([]string{"gov."})
|
|
r.Next = test.HandlerFunc(func(_ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (int, error) {
|
|
state := crequest.Request{W: w, Req: r}
|
|
qname := state.Name()
|
|
m := new(dns.Msg)
|
|
rcode := dns.RcodeServerFailure
|
|
if qname == "example.gov." {
|
|
m.SetReply(r)
|
|
rr, err := dns.NewRR("example.gov. 300 IN A 2.4.6.8")
|
|
if err != nil {
|
|
t.Fatalf("Failed to create Resource Record: %v", err)
|
|
}
|
|
m.Answer = []dns.RR{rr}
|
|
|
|
m.Authoritative = true
|
|
rcode = dns.RcodeSuccess
|
|
}
|
|
|
|
m.SetRcode(r, rcode)
|
|
w.WriteMsg(m)
|
|
return rcode, nil
|
|
})
|
|
err = r.Run(ctx)
|
|
if err != nil {
|
|
t.Fatalf("Failed to initialize route53: %v", err)
|
|
}
|
|
|
|
tests := []struct {
|
|
qname string
|
|
qtype uint16
|
|
wantRetCode int
|
|
wantAnswer []string // ownernames for the records in the additional section.
|
|
wantMsgRCode int
|
|
wantNS []string
|
|
expectedErr error
|
|
}{
|
|
// 0. example.org A found - success.
|
|
{
|
|
qname: "example.org",
|
|
qtype: dns.TypeA,
|
|
wantAnswer: []string{"example.org. 300 IN A 1.2.3.4"},
|
|
},
|
|
// 1. example.org AAAA found - success.
|
|
{
|
|
qname: "example.org",
|
|
qtype: dns.TypeAAAA,
|
|
wantAnswer: []string{"example.org. 300 IN AAAA 2001:db8:85a3::8a2e:370:7334"},
|
|
},
|
|
// 2. exampled.org PTR found - success.
|
|
{
|
|
qname: "example.org",
|
|
qtype: dns.TypePTR,
|
|
wantAnswer: []string{"example.org. 300 IN PTR ptr.example.org."},
|
|
},
|
|
// 3. sample.example.org points to example.org CNAME.
|
|
// Query must return both CNAME and A recs.
|
|
{
|
|
qname: "sample.example.org",
|
|
qtype: dns.TypeA,
|
|
wantAnswer: []string{
|
|
"sample.example.org. 300 IN CNAME example.org.",
|
|
"example.org. 300 IN A 1.2.3.4",
|
|
},
|
|
},
|
|
// 4. Explicit CNAME query for sample.example.org.
|
|
// Query must return just CNAME.
|
|
{
|
|
qname: "sample.example.org",
|
|
qtype: dns.TypeCNAME,
|
|
wantAnswer: []string{"sample.example.org. 300 IN CNAME example.org."},
|
|
},
|
|
// 5. Explicit SOA query for example.org.
|
|
{
|
|
qname: "example.org",
|
|
qtype: dns.TypeNS,
|
|
wantNS: []string{"org. 300 IN SOA ns-1536.awsdns-00.co.uk. awsdns-hostmaster.amazon.com. 1 7200 900 1209600 86400"},
|
|
},
|
|
// 6. AAAA query for split-example.org must return NODATA.
|
|
{
|
|
qname: "split-example.gov",
|
|
qtype: dns.TypeAAAA,
|
|
wantRetCode: dns.RcodeSuccess,
|
|
wantNS: []string{"org. 300 IN SOA ns-1536.awsdns-00.co.uk. awsdns-hostmaster.amazon.com. 1 7200 900 1209600 86400"},
|
|
},
|
|
// 7. Zone not configured.
|
|
{
|
|
qname: "badexample.com",
|
|
qtype: dns.TypeA,
|
|
wantRetCode: dns.RcodeServerFailure,
|
|
wantMsgRCode: dns.RcodeServerFailure,
|
|
},
|
|
// 8. No record found. Return SOA record.
|
|
{
|
|
qname: "bad.org",
|
|
qtype: dns.TypeA,
|
|
wantRetCode: dns.RcodeSuccess,
|
|
wantMsgRCode: dns.RcodeNameError,
|
|
wantNS: []string{"org. 300 IN SOA ns-1536.awsdns-00.co.uk. awsdns-hostmaster.amazon.com. 1 7200 900 1209600 86400"},
|
|
},
|
|
// 9. No record found. Fallthrough.
|
|
{
|
|
qname: "example.gov",
|
|
qtype: dns.TypeA,
|
|
wantAnswer: []string{"example.gov. 300 IN A 2.4.6.8"},
|
|
},
|
|
// 10. other-zone.example.org is stored in a different hosted zone. success
|
|
{
|
|
qname: "other-example.org",
|
|
qtype: dns.TypeA,
|
|
wantAnswer: []string{"other-example.org. 300 IN A 3.5.7.9"},
|
|
},
|
|
// 11. split-example.org only has A record. Expect NODATA.
|
|
{
|
|
qname: "split-example.org",
|
|
qtype: dns.TypeAAAA,
|
|
wantNS: []string{"org. 300 IN SOA ns-15.awsdns-00.co.uk. awsdns-hostmaster.amazon.com. 1 7200 900 1209600 86400"},
|
|
},
|
|
// 12. *.www.example.org is a wildcard CNAME to www.example.org.
|
|
{
|
|
qname: "a.www.example.org",
|
|
qtype: dns.TypeA,
|
|
wantAnswer: []string{
|
|
"a.www.example.org. 300 IN CNAME www.example.org.",
|
|
"www.example.org. 300 IN A 1.2.3.4",
|
|
},
|
|
},
|
|
}
|
|
|
|
for ti, tc := range tests {
|
|
req := new(dns.Msg)
|
|
req.SetQuestion(dns.Fqdn(tc.qname), tc.qtype)
|
|
|
|
rec := dnstest.NewRecorder(&test.ResponseWriter{})
|
|
code, err := r.ServeDNS(ctx, rec, req)
|
|
|
|
if !errors.Is(err, tc.expectedErr) {
|
|
t.Fatalf("Test %d: Expected error %v, but got %v", ti, tc.expectedErr, err)
|
|
}
|
|
if code != tc.wantRetCode {
|
|
t.Fatalf("Test %d: Expected returned status code %s, but got %s", ti, dns.RcodeToString[tc.wantRetCode], dns.RcodeToString[code])
|
|
}
|
|
|
|
if tc.wantMsgRCode != rec.Msg.Rcode {
|
|
t.Errorf("Test %d: Unexpected msg status code. Want: %s, got: %s", ti, dns.RcodeToString[tc.wantMsgRCode], dns.RcodeToString[rec.Msg.Rcode])
|
|
}
|
|
|
|
if len(tc.wantAnswer) != len(rec.Msg.Answer) {
|
|
t.Errorf("Test %d: Unexpected number of Answers. Want: %d, got: %d", ti, len(tc.wantAnswer), len(rec.Msg.Answer))
|
|
} else {
|
|
for i, gotAnswer := range rec.Msg.Answer {
|
|
if gotAnswer.String() != tc.wantAnswer[i] {
|
|
t.Errorf("Test %d: Unexpected answer.\nWant:\n\t%s\nGot:\n\t%s", ti, tc.wantAnswer[i], gotAnswer)
|
|
}
|
|
}
|
|
}
|
|
|
|
if len(tc.wantNS) != len(rec.Msg.Ns) {
|
|
t.Errorf("Test %d: Unexpected NS number. Want: %d, got: %d", ti, len(tc.wantNS), len(rec.Msg.Ns))
|
|
} else {
|
|
for i, ns := range rec.Msg.Ns {
|
|
got, ok := ns.(*dns.SOA)
|
|
if !ok {
|
|
t.Errorf("Test %d: Unexpected NS type. Want: SOA, got: %v", ti, reflect.TypeFor[*dns.SOA]())
|
|
}
|
|
if got.String() != tc.wantNS[i] {
|
|
t.Errorf("Test %d: Unexpected NS.\nWant: %v\nGot: %v", ti, tc.wantNS[i], got)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestMaybeUnescape(t *testing.T) {
|
|
for ti, tc := range []struct {
|
|
escaped, want string
|
|
wantErr error
|
|
}{
|
|
// 0. empty string is fine.
|
|
{escaped: "", want: ""},
|
|
// 1. non-escaped sequence.
|
|
{escaped: "example.com.", want: "example.com."},
|
|
// 2. escaped `*` as first label - OK.
|
|
{escaped: `\052.example.com`, want: "*.example.com"},
|
|
// 3. Escaped dot, 'a' and a hyphen. No idea why but we'll allow it.
|
|
{escaped: `weird\055ex\141mple\056com\056\056`, want: "weird-example.com.."},
|
|
// 4. escaped `*` in the middle - NOT OK.
|
|
{escaped: `e\052ample.com`, wantErr: errors.New("`*' only supported as wildcard (leftmost label)")},
|
|
// 5. Invalid character.
|
|
{escaped: `\000.example.com`, wantErr: errors.New(`invalid character: \000`)},
|
|
// 6. Invalid escape sequence in the middle.
|
|
{escaped: `example\0com`, wantErr: errors.New(`invalid escape sequence: '\0co'`)},
|
|
// 7. Invalid escape sequence at the end.
|
|
{escaped: `example.com\0`, wantErr: errors.New(`invalid escape sequence: '\0'`)},
|
|
} {
|
|
got, gotErr := maybeUnescape(tc.escaped)
|
|
if !errors.Is(gotErr, tc.wantErr) && !reflect.DeepEqual(tc.wantErr, gotErr) {
|
|
t.Fatalf("Test %d: Expected error: `%v', but got: `%v'", ti, tc.wantErr, gotErr)
|
|
}
|
|
if tc.want != got {
|
|
t.Errorf("Test %d: Expected unescaped: `%s', but got: `%s'", ti, tc.want, got)
|
|
}
|
|
}
|
|
}
|