mirror of
https://github.com/coredns/coredns.git
synced 2026-10-08 19:45:21 -04:00
plugin/rewrite: Fixes a nil pointer dereference panic in ResponseReverter.WriteMsg (#8519)
ResponseReverter.WriteMsg calls res1.Copy() without checking res1 for nil, so any plugin further down the chain that writes a nil response (for example a handler returning (dns.RcodeSuccess, nil) after w.WriteMsg(nil)) panics here. Return an error instead, mirroring the nil guard recently added to plugin/cache's ResponseWriter.WriteMsg (#8512). Signed-off-by: zjncs <18910855655@163.com>
This commit is contained in:
@@ -370,3 +370,22 @@ func noQuestionMsgPrinter(_ context.Context, w dns.ResponseWriter, _ *dns.Msg) (
|
||||
|
||||
return dns.RcodeSuccess, nil
|
||||
}
|
||||
|
||||
func TestResponseReverterWriteMsgNilResponse(t *testing.T) {
|
||||
req := new(dns.Msg)
|
||||
req.SetQuestion("service.example.org.", dns.TypeA)
|
||||
|
||||
rec := dnstest.NewRecorder(&test.ResponseWriter{})
|
||||
rw := NewResponseReverter(rec, req, NewRevertPolicy(false, false))
|
||||
|
||||
defer func() {
|
||||
if r := recover(); r != nil {
|
||||
t.Fatalf("ResponseReverter.WriteMsg panicked on nil response: %v", r)
|
||||
}
|
||||
}()
|
||||
|
||||
err := rw.WriteMsg(nil)
|
||||
if err == nil {
|
||||
t.Error("Expected error when passing nil response to WriteMsg, got nil")
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user