Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-12-09 03:45:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

plugin/health: make reload work (#1585)

Browse Source 
* plugin/health: make reload work

Remove the once.Do from the startup, so we can re-bind the HTTP
listener. Also clarify the usage of health in multiple server blocks
(this is not the best approach - but there isn't a generic solution at
this point).

Manual tested as we lack testing infra, i.e kill -SIGUSR1 and some
CURLing of the health endpoint.

* Readme test fix

* update

* dont need this
This commit is contained in:
Miek Gieben
2018-03-02 21:40:14 -08:00
committed by GitHub
parent acf823cd78
commit 804f745951
3 changed files with 37 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
plugin/health/setup.go
View File

@@ -68,7 +68,7 @@ func setup(c *caddy.Controller) error {
})
c.OnStartup(h.OnStartup)
c.OnFinalShutdown(h.OnShutdown)
c.OnShutdown(h.OnShutdown)
// Don't do AddPlugin, as health is not *really* a plugin just a separate webserver running.
return nil