Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2026-07-12 10:40:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

request/cache: bind responses and entries to QCLASS (#8272)

Browse Source 
Signed-off-by: houyuwushang <liuluoqianqiu@outlook.com>
This commit is contained in:
houyuwushang
2026-07-11 06:18:27 +08:00
committed by GitHub
parent 2d42f0e8f5
commit 6ec70a0603
8 changed files with 89 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
request/request.go
View File

@@ -340,8 +340,8 @@ func (r *Request) Clear() {
r.do = false
}
// Match checks if the reply matches the qname and qtype from the request, it returns
// false when they don't match.
// Match checks if the reply matches the qname, qtype and qclass from the request.
// It returns false when they don't match.
func (r *Request) Match(reply *dns.Msg) bool {
if len(reply.Question) != 1 {
return false
@@ -359,5 +359,9 @@ func (r *Request) Match(reply *dns.Msg) bool {
return false
}
if reply.Question[0].Qclass != r.QClass() {
return false
}
return true
}

5
request/request_test.go
View File

@@ -310,6 +310,11 @@ func TestRequestMatch(t *testing.T) {
t.Errorf("Failed to match %s %d, got %t, expected %t", "example.com.", dns.TypeA, b, true)
}
reply.Question[0].Qclass = dns.ClassCHAOS
if b := st.Match(reply); b {
t.Errorf("Matched response class %d with request class %d", reply.Question[0].Qclass, st.QClass())
}
reply.SetQuestion("example.org.", dns.TypeA)
if b := st.Match(reply); b {
t.Errorf("Failed to match %s %d, got %t, expected %t", "example.org.", dns.TypeA, b, false)