fix(lint): address G114 gosec findings in ready, pprof, and health plugins (#7798)

Replace http.Serve() with http.Server{} configured with timeouts to
address G114 gosec findings (HTTP server without timeouts). This
prevents potential slowloris attacks and resource exhaustion.

Changes:
- Add ReadTimeout, WriteTimeout, IdleTimeout (5s each) to HTTP servers
- Use srv.Shutdown(ctx) for graceful shutdown instead of ln.Close()
- Follow existing pattern from plugin/metrics

Fixes part of #7793

Signed-off-by: Azeez Syed <syedazeez337@gmail.com>
This commit is contained in:
Syed Azeez
2026-01-01 14:55:37 +05:30
committed by GitHub
parent 7b38eb8625
commit 6dca5b26d1
3 changed files with 59 additions and 13 deletions

View File

@@ -5,10 +5,12 @@
package ready
import (
"context"
"io"
"net"
"net/http"
"sync"
"time"
clog "github.com/coredns/coredns/plugin/pkg/log"
"github.com/coredns/coredns/plugin/pkg/reuseport"
@@ -26,10 +28,13 @@ type ready struct {
sync.RWMutex
ln net.Listener
srv *http.Server
done bool
mux *http.ServeMux
}
const shutdownTimeout = 5 * time.Second
func (rd *ready) onStartup() error {
ln, err := reuseport.Listen("tcp", rd.Addr)
if err != nil {
@@ -61,8 +66,14 @@ func (rd *ready) onStartup() error {
io.WriteString(w, notReadyPlugins)
})
// #nosec G114 -- TODO
go func() { http.Serve(rd.ln, rd.mux) }()
rd.srv = &http.Server{
Handler: rd.mux,
ReadTimeout: 5 * time.Second,
WriteTimeout: 5 * time.Second,
IdleTimeout: 5 * time.Second,
}
go func() { rd.srv.Serve(rd.ln) }()
return nil
}
@@ -76,7 +87,11 @@ func (rd *ready) onFinalShutdown() error {
uniqAddr.Unset(rd.Addr)
rd.ln.Close()
ctx, cancel := context.WithTimeout(context.Background(), shutdownTimeout)
defer cancel()
if err := rd.srv.Shutdown(ctx); err != nil {
log.Infof("Failed to stop ready http server: %s", err)
}
rd.done = false
return nil
}