mirror of
https://github.com/coredns/coredns.git
synced 2025-12-06 10:25:10 -05:00
Add support for fallthrough to the grpc plugin (#7359)
Fixes: https://github.com/coredns/coredns/issues/7358 Signed-off-by: Blake Barnett <bbarnett@groq.com>
This commit is contained in:
@@ -7,6 +7,7 @@ import (
|
||||
"testing"
|
||||
|
||||
"github.com/coredns/caddy"
|
||||
"github.com/coredns/coredns/plugin/pkg/fall"
|
||||
)
|
||||
|
||||
func TestSetup(t *testing.T) {
|
||||
@@ -152,3 +153,47 @@ nameserver 10.10.255.253`), 0666); err != nil {
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestSetupFallthrough(t *testing.T) {
|
||||
tests := []struct {
|
||||
input string
|
||||
shouldErr bool
|
||||
expectedFallthrough fall.F
|
||||
expectedErr string
|
||||
}{
|
||||
// positive cases
|
||||
{`grpc . 127.0.0.1 {
|
||||
fallthrough
|
||||
}`, false, fall.Root, ""},
|
||||
{`grpc . 127.0.0.1 {
|
||||
fallthrough example.org
|
||||
}`, false, fall.F{Zones: []string{"example.org."}}, ""},
|
||||
{`grpc . 127.0.0.1 {
|
||||
fallthrough example.org example.com
|
||||
}`, false, fall.F{Zones: []string{"example.org.", "example.com."}}, ""},
|
||||
{`grpc . 127.0.0.1`, false, fall.Zero, ""},
|
||||
}
|
||||
|
||||
for i, test := range tests {
|
||||
c := caddy.NewTestController("dns", test.input)
|
||||
g, err := parseGRPC(c)
|
||||
|
||||
if test.shouldErr && err == nil {
|
||||
t.Errorf("Test %d: expected error but found none for input %s", i, test.input)
|
||||
}
|
||||
|
||||
if err != nil {
|
||||
if !test.shouldErr {
|
||||
t.Errorf("Test %d: expected no error but found one for input %s, got: %v", i, test.input, err)
|
||||
}
|
||||
|
||||
if !strings.Contains(err.Error(), test.expectedErr) {
|
||||
t.Errorf("Test %d: expected error to contain: %v, found error: %v, input: %s", i, test.expectedErr, err, test.input)
|
||||
}
|
||||
}
|
||||
|
||||
if !test.shouldErr && !g.Fall.Equal(test.expectedFallthrough) {
|
||||
t.Errorf("Test %d: expected fallthrough %+v, got %+v", i, test.expectedFallthrough, g.Fall)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user