mirror of
https://github.com/coredns/coredns.git
synced 2025-12-07 10:55:17 -05:00
fix(sign): reject invalid UTF‑8 dbfile token (#7589)
The coredns/caddy lexer replaces invalid UTF‑8 bytes in tokens with U+FFFD. When that lossy-decoded value is used as `dbfile` in the sign plugin, the source zone file path never exists. On startup/refresh, the `resign()` function sees the signed file missing and triggers signing. Consequently `Sign()` then fails opening the bogus path, the signed file is never created, and the cycle repeats across all expanded origins (e.g., reverse CIDRs), causing unbounded churn/OOM. Validate `dbfile` in setup and error if it contains U+FFFD. Add a regression test. Note: Unicode paths are supported; only U+FFFD (replacement-rune) is rejected. Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
This commit is contained in:
@@ -73,3 +73,14 @@ func TestParse(t *testing.T) {
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// With setup validation in place, an invalid utf-8 dbfile token must cause parse() to error.
|
||||
func TestParseRejectsInvalidDbfileToken(t *testing.T) {
|
||||
input := "sign \"\xff\" 8.44.in-addr.arpa. 9.44.in-addr.arpa. {}"
|
||||
c := caddy.NewTestController("dns", input)
|
||||
|
||||
_, err := parse(c)
|
||||
if err == nil {
|
||||
t.Fatalf("expected parse to fail for invalid dbfile token")
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user