Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2026-10-27 20:55:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

plugin/clouddns: add refresh directive (#8616)

Browse Source 
Brings clouddns to parity with route53, which already exposes a
refresh directive to control how often zones are re-synced. clouddns
currently hardcodes this to 1 minute (delay := 1 * time.Minute in Run)
with no way to change it.

Adds a refresh field to the CloudDNS struct, threads it through New(),
and has Run() use h.refresh instead of the hardcoded delay. Parses the
refresh directive in setup() mirroring route53's exact validation
(accepts a plain number as seconds or a duration string, must be
greater than 0).

Extends TestSetupCloudDNS with refresh coverage (valid duration, valid
plain number, missing arg, non-numeric, zero, negative). Verified it
fails without the setup.go change (unknown property error) and passes
with it.

Signed-off-by: stackedbyaradhya <aradhyaj736@gmail.com>
This commit is contained in:
Aradhya Jain
2026-10-09 07:17:32 +05:30
committed by GitHub
parent 45ac7fe659
commit 538c3554bc
5 changed files with 67 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
plugin/clouddns/clouddns.go
View File

@@ -28,6 +28,7 @@ type CloudDNS struct {
zoneNames []string
client gcpDNS
upstream *upstream.Upstream
refresh time.Duration
zMu sync.RWMutex
zones zones
@@ -46,8 +47,9 @@ type zones map[string][]*zone
// string of project name and hosted zone name lists as its values, validates
// that each domain name/zone id pair does exist, and returns a new *CloudDNS.
// In addition to this, upstream is passed for doing recursive queries against CNAMEs.
// refresh sets how often the zones are refreshed from Cloud DNS.
// Returns error if it cannot verify any given domain name/zone id pair.
func New(_ctx context.Context, c gcpDNS, keys map[string][]string, up *upstream.Upstream) (*CloudDNS, error) {
func New(_ctx context.Context, c gcpDNS, keys map[string][]string, up *upstream.Upstream, refresh time.Duration) (*CloudDNS, error) {
zones := make(map[string][]*zone, len(keys))
zoneNames := make([]string, 0, len(keys))
for dnsName, hostedZoneDetails := range keys {
@@ -72,6 +74,7 @@ func New(_ctx context.Context, c gcpDNS, keys map[string][]string, up *upstream.
zoneNames: zoneNames,
zones: zones,
upstream: up,
refresh: refresh,
}, nil
}
@@ -82,11 +85,10 @@ func (h *CloudDNS) Run(ctx context.Context) error {
return err
}
go func() {
delay := 1 * time.Minute
timer := time.NewTimer(delay)
timer := time.NewTimer(h.refresh)
defer timer.Stop()
for {
timer.Reset(delay)
timer.Reset(h.refresh)
select {
case <-ctx.Done():
log.Debugf("Breaking out of CloudDNS update loop for %v: %v", h.zoneNames, ctx.Err())